From 6889b82a5c9ecc6bd178760c66653d7af0121162 Mon Sep 17 00:00:00 2001 From: Richard-Qin-X Date: Fri, 28 Aug 2026 14:25:42 +0800 Subject: [CodeGen] Separate assembly emission ownership --- backend/include/rcc/CodeGen/AsmPrinter.h | 45 +++++++++++++++++++--- .../include/rcc/CodeGen/TargetLoweringObjectFile.h | 34 ++++++++++++++++ backend/include/rcc/CodeGen/TargetMCInstLowering.h | 41 ++------------------ .../rcc/Target/RISCV/RISCVMCTargetLowering.h | 31 +-------------- 4 files changed, 80 insertions(+), 71 deletions(-) create mode 100644 backend/include/rcc/CodeGen/TargetLoweringObjectFile.h (limited to 'backend/include/rcc') diff --git a/backend/include/rcc/CodeGen/AsmPrinter.h b/backend/include/rcc/CodeGen/AsmPrinter.h index 82bad7d..4145093 100644 --- a/backend/include/rcc/CodeGen/AsmPrinter.h +++ b/backend/include/rcc/CodeGen/AsmPrinter.h @@ -3,14 +3,24 @@ #ifndef RCC_CODEGEN_ASMPRINTER_H #define RCC_CODEGEN_ASMPRINTER_H +#include "rcc/IR/DataLayout.h" #include "rcc/Support/Error.h" +#include +#include +#include + namespace rcc { class CompilationUnit; +class GlobalInitializer; class MachineFunction; +class MachineJumpTableEntry; class MachineMCContext; +struct GenericConstantData; +class TargetConstant; class TargetDescription; +class TargetLoweringObjectFile; class TargetMCInstLowering; namespace mc { @@ -25,31 +35,56 @@ struct AsmPrinterOptions final { bool VerifyInput = true; }; -class AsmPrinter final { +class AsmPrinter { public: AsmPrinter(const TargetDescription &Target, const TargetMCInstLowering &Lowering, + const TargetLoweringObjectFile &ObjectFile, DataLayout Layout, MachineMCContext &Context, mc::MCStreamer &Streamer, AsmPrinterOptions Options = {}) noexcept - : Target(&Target), Lowering(&Lowering), Context(&Context), Streamer(&Streamer), - Options(Options) {} + : Target(&Target), Lowering(&Lowering), ObjectFile(&ObjectFile), Layout(std::move(Layout)), + Context(&Context), Streamer(&Streamer), Options(Options) {} + virtual ~AsmPrinter() = default; [[nodiscard]] Expected emitCompilationUnit(const CompilationUnit &Unit); [[nodiscard]] Expected emitFunction(const MachineFunction &Function); +protected: + [[nodiscard]] virtual Expected emitStartOfAsmFile(); + [[nodiscard]] virtual Expected emitEndOfAsmFile(); + [[nodiscard]] virtual Expected emitTargetConstant(const TargetConstant &Constant); + [[nodiscard]] virtual Expected emitTargetJumpTable(const MachineFunction &Function, + const MachineJumpTableEntry &Entry); + + [[nodiscard]] MachineMCContext &machineContext() const noexcept { + return *Context; + } + + [[nodiscard]] mc::MCStreamer &streamer() const noexcept { + return *Streamer; + } + private: [[nodiscard]] Expected verifyFunction(const MachineFunction &Function) const; [[nodiscard]] Expected emitGlobalObjects(const CompilationUnit &Unit); + [[nodiscard]] Expected emitFunctionImpl(const MachineFunction &Function); [[nodiscard]] Expected emitFunctionBody(const MachineFunction &Function); [[nodiscard]] Expected emitConstantPool(const MachineFunction &Function); [[nodiscard]] Expected emitJumpTables(const MachineFunction &Function); + [[nodiscard]] Expected emitGenericConstant(const GenericConstantData &Constant, + std::uint64_t AllocationSize, + std::size_t Depth = 0); + [[nodiscard]] Expected emitGlobalInitializer(const GlobalInitializer &Initializer, + std::size_t Depth = 0); const TargetDescription *Target; const TargetMCInstLowering *Lowering; + const TargetLoweringObjectFile *ObjectFile; + DataLayout Layout; MachineMCContext *Context; mc::MCStreamer *Streamer; AsmPrinterOptions Options; - bool UnitEmissionStarted = false; - bool UnitEmissionFinished = false; + bool EmissionStarted = false; + bool EmissionFinished = false; }; } // namespace rcc diff --git a/backend/include/rcc/CodeGen/TargetLoweringObjectFile.h b/backend/include/rcc/CodeGen/TargetLoweringObjectFile.h new file mode 100644 index 0000000..f415e4f --- /dev/null +++ b/backend/include/rcc/CodeGen/TargetLoweringObjectFile.h @@ -0,0 +1,34 @@ +// SPDX-License-Identifier: GPL-3.0-or-later + +#ifndef RCC_CODEGEN_TARGETLOWERINGOBJECTFILE_H +#define RCC_CODEGEN_TARGETLOWERINGOBJECTFILE_H + +#include "rcc/MC/MCSection.h" +#include "rcc/Support/Error.h" + +namespace rcc { + +struct GlobalObjectDesc; +class MachineConstantPoolEntry; +class MachineFunction; +class MachineJumpTableEntry; +class MachineMCContext; + +class TargetLoweringObjectFile { +public: + virtual ~TargetLoweringObjectFile() = default; + + [[nodiscard]] virtual Expected + textSection(const MachineFunction &Function) const = 0; + [[nodiscard]] virtual Expected + globalSection(const GlobalObjectDesc &Object, MachineMCContext &Context) const = 0; + [[nodiscard]] virtual Expected + constantPoolSection(const MachineFunction &Function, + const MachineConstantPoolEntry &Entry) const = 0; + [[nodiscard]] virtual Expected + jumpTableSection(const MachineFunction &Function, const MachineJumpTableEntry &Entry) const = 0; +}; + +} // namespace rcc + +#endif // RCC_CODEGEN_TARGETLOWERINGOBJECTFILE_H diff --git a/backend/include/rcc/CodeGen/TargetMCInstLowering.h b/backend/include/rcc/CodeGen/TargetMCInstLowering.h index 875d2dd..eacb48e 100644 --- a/backend/include/rcc/CodeGen/TargetMCInstLowering.h +++ b/backend/include/rcc/CodeGen/TargetMCInstLowering.h @@ -3,23 +3,16 @@ #ifndef RCC_CODEGEN_TARGETMCINSTLOWERING_H #define RCC_CODEGEN_TARGETMCINSTLOWERING_H +#include "rcc/MC/MCExpr.h" #include "rcc/MC/MCInst.h" #include "rcc/MC/MCInstPrinter.h" -#include "rcc/MC/MCSection.h" #include "rcc/MC/MCStreamer.h" #include "rcc/Support/Error.h" namespace rcc { -class MachineConstantPoolEntry; -class GlobalInitializer; -struct GlobalObjectDesc; -class MachineFunction; class MachineInstr; -class MachineJumpTableEntry; class MachineMCContext; -struct GenericConstantData; -class TargetConstant; class TargetMCInstLowering { public: @@ -30,38 +23,12 @@ public: [[nodiscard]] virtual Expected lowerInstruction(const MachineInstr &Instruction, MachineMCContext &Context) const = 0; + [[nodiscard]] virtual Expected + lowerSymbolExpression(mc::MCExprRef Expression, std::uint32_t TargetFlags) const = 0; + [[nodiscard]] virtual Expected emitTerminalInstruction(const MachineInstr &Instruction, MachineMCContext &Context, mc::MCStreamer &Streamer) const; - - [[nodiscard]] virtual Expected - textSection(const MachineFunction &Function) const = 0; - [[nodiscard]] virtual Expected - globalSection(const GlobalObjectDesc &Object, MachineMCContext &Context) const = 0; - [[nodiscard]] virtual Expected - constantPoolSection(const MachineFunction &Function, - const MachineConstantPoolEntry &Entry) const = 0; - [[nodiscard]] virtual Expected - jumpTableSection(const MachineFunction &Function, const MachineJumpTableEntry &Entry) const = 0; - - [[nodiscard]] virtual Expected emitFileHeader(MachineMCContext &Context, - mc::MCStreamer &Streamer) const; - [[nodiscard]] virtual Expected emitFileTrailer(MachineMCContext &Context, - mc::MCStreamer &Streamer) const; - [[nodiscard]] virtual Expected emitGenericConstant(const GenericConstantData &Constant, - std::uint64_t Size, - MachineMCContext &Context, - mc::MCStreamer &Streamer) const; - [[nodiscard]] virtual Expected emitGlobalInitializer(const GlobalInitializer &Initializer, - MachineMCContext &Context, - mc::MCStreamer &Streamer) const; - [[nodiscard]] virtual Expected emitTargetConstant(const TargetConstant &Constant, - MachineMCContext &Context, - mc::MCStreamer &Streamer) const; - [[nodiscard]] virtual Expected emitTargetJumpTable(const MachineFunction &Function, - const MachineJumpTableEntry &Entry, - MachineMCContext &Context, - mc::MCStreamer &Streamer) const; }; } // namespace rcc diff --git a/backend/include/rcc/Target/RISCV/RISCVMCTargetLowering.h b/backend/include/rcc/Target/RISCV/RISCVMCTargetLowering.h index fd620ad..3713bb5 100644 --- a/backend/include/rcc/Target/RISCV/RISCVMCTargetLowering.h +++ b/backend/include/rcc/Target/RISCV/RISCVMCTargetLowering.h @@ -19,39 +19,12 @@ public: [[nodiscard]] Expected lowerInstruction(const MachineInstr &Instruction, MachineMCContext &Context) const override; + [[nodiscard]] Expected + lowerSymbolExpression(mc::MCExprRef Expression, std::uint32_t TargetFlags) const override; [[nodiscard]] Expected emitTerminalInstruction(const MachineInstr &Instruction, MachineMCContext &Context, mc::MCStreamer &Streamer) const override; - [[nodiscard]] Expected - textSection(const MachineFunction &Function) const override; - [[nodiscard]] Expected globalSection(const GlobalObjectDesc &Object, - MachineMCContext &Context) const override; - [[nodiscard]] Expected - constantPoolSection(const MachineFunction &Function, - const MachineConstantPoolEntry &Entry) const override; - [[nodiscard]] Expected - jumpTableSection(const MachineFunction &Function, - const MachineJumpTableEntry &Entry) const override; - - [[nodiscard]] Expected emitFileHeader(MachineMCContext &Context, - mc::MCStreamer &Streamer) const override; - [[nodiscard]] Expected emitFileTrailer(MachineMCContext &Context, - mc::MCStreamer &Streamer) const override; - [[nodiscard]] Expected emitGenericConstant(const GenericConstantData &Constant, - std::uint64_t Size, MachineMCContext &Context, - mc::MCStreamer &Streamer) const override; - [[nodiscard]] Expected emitGlobalInitializer(const GlobalInitializer &Initializer, - MachineMCContext &Context, - mc::MCStreamer &Streamer) const override; - [[nodiscard]] Expected emitTargetConstant(const TargetConstant &Constant, - MachineMCContext &Context, - mc::MCStreamer &Streamer) const override; - [[nodiscard]] Expected emitTargetJumpTable(const MachineFunction &Function, - const MachineJumpTableEntry &Entry, - MachineMCContext &Context, - mc::MCStreamer &Streamer) const override; - private: const TargetDescription *Target; RISCVInstPrinter Printer; -- cgit v1.2.3