From e72ad2cd524ff38f162a23d69da5f78494d337ae Mon Sep 17 00:00:00 2001 From: Richard-Qin-X Date: Fri, 28 Aug 2026 13:45:07 +0800 Subject: [CodeGen] Centralize machine instruction erasure --- backend/lib/CodeGen/MachineCSE.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'backend/lib/CodeGen/MachineCSE.cpp') diff --git a/backend/lib/CodeGen/MachineCSE.cpp b/backend/lib/CodeGen/MachineCSE.cpp index 7bd5a22..353cbaa 100644 --- a/backend/lib/CodeGen/MachineCSE.cpp +++ b/backend/lib/CodeGen/MachineCSE.cpp @@ -258,15 +258,12 @@ replacementPairs(const MachineInstr &Available, const MachineInstr &Redundant, replaceAndErase(MachineInstr &Redundant, const std::vector> &Replacements, MachineRegisterInfo &Registers) { - MachineBasicBlock *Block = Redundant.parent(); - if (Block == nullptr) - return makeUnexpected(ErrorCode::InternalError, "machine CSE candidate is detached"); for (const auto &[OldReg, NewReg] : Replacements) { auto Replaced = Registers.replaceRegWith(OldReg, NewReg); if (!Replaced) return std::unexpected(Replaced.error()); } - auto Removed = Block->removeInstruction(Redundant); + auto Removed = Redundant.eraseFromParent(); if (!Removed) return std::unexpected(Removed.error()); for (const auto &[OldReg, NewReg] : Replacements) { -- cgit v1.2.3