[GlobalISel] Split the generic pipeline components

8 files changed, 222 insertions, 163 deletions

diff --git a/backend/include/rcc/CodeGen/GlobalISel/InstructionSelect.h b/backend/include/rcc/CodeGen/GlobalISel/InstructionSelect.h
new file mode 100644
index 0000000..0c034cd
--- /dev/null
+++ b/backend/include/rcc/CodeGen/GlobalISel/InstructionSelect.h
@@ -0,0 +1,31 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+#ifndef RCC_CODEGEN_GLOBALISEL_INSTRUCTIONSELECT_H
+#define RCC_CODEGEN_GLOBALISEL_INSTRUCTIONSELECT_H
+
+#include "rcc/CodeGen/GlobalISel/InstructionSelector.h"
+#include "rcc/CodeGen/MachinePass.h"
+
+namespace rcc {
+
+class InstructionSelect final : public MachineFunctionPass {
+public:
+  explicit InstructionSelect(const InstructionSelector *Info) : Info(Info) {}
+  explicit InstructionSelect(const InstructionSelector &Info) : Info(&Info) {}
+
+  [[nodiscard]] const MachinePassContract &contract() const noexcept override;
+  [[nodiscard]] Expected<MachinePassResult> run(MachineFunction &Function,
+                                                const TargetDescription &Target,
+                                                MachineAnalysisManager &Analyses) override;
+
+private:
+  [[nodiscard]] Expected<MachinePassResult> runImplementation(MachineFunction &Function,
+                                                              const TargetDescription &Target,
+                                                              MachineActionReplay &Actions);
+
+  const InstructionSelector *Info;
+};
+
+} // namespace rcc
+
+#endif // RCC_CODEGEN_GLOBALISEL_INSTRUCTIONSELECT_H
diff --git a/backend/include/rcc/CodeGen/GlobalISel/InstructionSelector.h b/backend/include/rcc/CodeGen/GlobalISel/InstructionSelector.h
new file mode 100644
index 0000000..4c69606
--- /dev/null
+++ b/backend/include/rcc/CodeGen/GlobalISel/InstructionSelector.h
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+#ifndef RCC_CODEGEN_GLOBALISEL_INSTRUCTIONSELECTOR_H
+#define RCC_CODEGEN_GLOBALISEL_INSTRUCTIONSELECTOR_H
+
+#include "rcc/Support/Error.h"
+
+namespace rcc {
+
+class MachineFunction;
+class MachineInstr;
+class TargetDescription;
+
+class InstructionSelector {
+public:
+  virtual ~InstructionSelector() = default;
+
+  [[nodiscard]] virtual Expected<void> select(MachineInstr &Instruction, MachineFunction &Function,
+                                              const TargetDescription &Target) const = 0;
+
+  // Selection matching is read-only and completes before select() mutates MachineIR.
+  [[nodiscard]] virtual Expected<void> canSelect(const MachineInstr &, const MachineFunction &,
+                                                 const TargetDescription &) const {
+    return {};
+  }
+
+  [[nodiscard]] virtual Expected<void>
+  constrainSelectedInstruction(MachineInstr &, MachineFunction &, const TargetDescription &) const {
+    return {};
+  }
+};
+
+} // namespace rcc
+
+#endif // RCC_CODEGEN_GLOBALISEL_INSTRUCTIONSELECTOR_H
diff --git a/backend/include/rcc/CodeGen/GlobalISel/Legalizer.h b/backend/include/rcc/CodeGen/GlobalISel/Legalizer.h
new file mode 100644
index 0000000..7f86d16
--- /dev/null
+++ b/backend/include/rcc/CodeGen/GlobalISel/Legalizer.h
@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+#ifndef RCC_CODEGEN_GLOBALISEL_LEGALIZER_H
+#define RCC_CODEGEN_GLOBALISEL_LEGALIZER_H
+
+#include "rcc/CodeGen/GlobalISel/LegalizerInfo.h"
+#include "rcc/CodeGen/MachinePass.h"
+
+#include <memory>
+
+namespace rcc {
+
+class Legalizer final : public MachineFunctionPass {
+public:
+  explicit Legalizer(const LegalizerInfo *Info) : Info(Info) {}
+  explicit Legalizer(const LegalizerInfo &Info) : Info(&Info) {}
+  explicit Legalizer(std::unique_ptr<LegalizerInfo> Info)
+      : OwnedInfo(std::move(Info)), Info(OwnedInfo.get()) {}
+
+  [[nodiscard]] const MachinePassContract &contract() const noexcept override;
+  [[nodiscard]] Expected<MachinePassResult> run(MachineFunction &Function,
+                                                const TargetDescription &Target,
+                                                MachineAnalysisManager &Analyses) override;
+
+private:
+  [[nodiscard]] Expected<MachinePassResult> runImplementation(MachineFunction &Function,
+                                                              const TargetDescription &Target,
+                                                              MachineActionReplay &Actions);
+
+  std::unique_ptr<LegalizerInfo> OwnedInfo;
+  const LegalizerInfo *Info = nullptr;
+};
+
+} // namespace rcc
+
+#endif // RCC_CODEGEN_GLOBALISEL_LEGALIZER_H
diff --git a/backend/include/rcc/CodeGen/GlobalISel/LegalizerInfo.h b/backend/include/rcc/CodeGen/GlobalISel/LegalizerInfo.h
new file mode 100644
index 0000000..218a4c6
--- /dev/null
+++ b/backend/include/rcc/CodeGen/GlobalISel/LegalizerInfo.h
@@ -0,0 +1,54 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+#ifndef RCC_CODEGEN_GLOBALISEL_LEGALIZERINFO_H
+#define RCC_CODEGEN_GLOBALISEL_LEGALIZERINFO_H
+
+#include "rcc/Support/Error.h"
+
+#include <cstdint>
+
+namespace rcc {
+
+class MachineFunction;
+class MachineInstr;
+class TargetDescription;
+
+enum class LegalizationAction : std::uint8_t {
+  Legal,
+  Unsupported,
+  Custom,
+  Lower,
+  Libcall,
+  WidenScalar,
+  NarrowScalar,
+  MoreElements,
+  FewerElements,
+  Bitcast,
+  ChangeElementType,
+  ChangeAddressSpace,
+};
+
+class LegalizerInfo {
+public:
+  virtual ~LegalizerInfo() = default;
+
+  [[nodiscard]] virtual Expected<LegalizationAction>
+  classify(const MachineInstr &Instruction, const MachineFunction &Function,
+           const TargetDescription &Target) const = 0;
+
+  [[nodiscard]] virtual Expected<void> lower(MachineInstr &Instruction, MachineFunction &Function,
+                                             const TargetDescription &Target,
+                                             LegalizationAction Action) const = 0;
+
+  // This hook performs read-only target checks before a lowering mutation is committed.
+  [[nodiscard]] virtual Expected<void> validateLowering(const MachineInstr &,
+                                                        const MachineFunction &,
+                                                        const TargetDescription &,
+                                                        LegalizationAction) const {
+    return {};
+  }
+};
+
+} // namespace rcc
+
+#endif // RCC_CODEGEN_GLOBALISEL_LEGALIZERINFO_H
diff --git a/backend/include/rcc/CodeGen/GlobalISel/RegBankSelect.h b/backend/include/rcc/CodeGen/GlobalISel/RegBankSelect.h
new file mode 100644
index 0000000..256d748
--- /dev/null
+++ b/backend/include/rcc/CodeGen/GlobalISel/RegBankSelect.h
@@ -0,0 +1,27 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+#ifndef RCC_CODEGEN_GLOBALISEL_REGBANKSELECT_H
+#define RCC_CODEGEN_GLOBALISEL_REGBANKSELECT_H
+
+#include "rcc/CodeGen/MachinePass.h"
+#include "rcc/CodeGen/RegisterBankInfo.h"
+
+namespace rcc {
+
+class RegBankSelect final : public MachineFunctionPass {
+public:
+  explicit RegBankSelect(const RegisterBankInfo *Info) : Info(Info) {}
+  explicit RegBankSelect(const RegisterBankInfo &Info) : Info(&Info) {}
+
+  [[nodiscard]] const MachinePassContract &contract() const noexcept override;
+  [[nodiscard]] Expected<MachinePassResult> run(MachineFunction &Function,
+                                                const TargetDescription &Target,
+                                                MachineAnalysisManager &Analyses) override;
+
+private:
+  const RegisterBankInfo *Info;
+};
+
+} // namespace rcc
+
+#endif // RCC_CODEGEN_GLOBALISEL_REGBANKSELECT_H
diff --git a/backend/include/rcc/CodeGen/MachinePipelinePasses.h b/backend/include/rcc/CodeGen/MachinePipelinePasses.h
deleted file mode 100644
index 1187e4a..0000000
--- a/backend/include/rcc/CodeGen/MachinePipelinePasses.h
+++ /dev/null
@@ -1,68 +0,0 @@
-// SPDX-License-Identifier: GPL-3.0-or-later
-
-#ifndef RCC_CODEGEN_MACHINEPIPELINEPASSES_H
-#define RCC_CODEGEN_MACHINEPIPELINEPASSES_H
-
-#include "rcc/CodeGen/MachinePass.h"
-#include "rcc/CodeGen/TargetCodeGen.h"
-
-#include <memory>
-
-namespace rcc {
-
-class LegalizerPass final : public MachineFunctionPass {
-public:
-  explicit LegalizerPass(const TargetLegalizerInfo *Info) : Info(Info) {}
-  explicit LegalizerPass(const TargetLegalizerInfo &Info) : Info(&Info) {}
-  explicit LegalizerPass(std::unique_ptr<TargetLegalizerInfo> Info)
-      : OwnedInfo(std::move(Info)), Info(OwnedInfo.get()) {}
-
-  [[nodiscard]] const MachinePassContract &contract() const noexcept override;
-  [[nodiscard]] Expected<MachinePassResult> run(MachineFunction &Function,
-                                                const TargetDescription &Target,
-                                                MachineAnalysisManager &Analyses) override;
-
-private:
-  [[nodiscard]] Expected<MachinePassResult> runImplementation(MachineFunction &Function,
-                                                              const TargetDescription &Target,
-                                                              MachineActionReplay &Actions);
-
-  std::unique_ptr<TargetLegalizerInfo> OwnedInfo;
-  const TargetLegalizerInfo *Info = nullptr;
-};
-
-class RegisterBankSelectPass final : public MachineFunctionPass {
-public:
-  explicit RegisterBankSelectPass(const TargetRegisterBankInfo *Info) : Info(Info) {}
-  explicit RegisterBankSelectPass(const TargetRegisterBankInfo &Info) : Info(&Info) {}
-
-  [[nodiscard]] const MachinePassContract &contract() const noexcept override;
-  [[nodiscard]] Expected<MachinePassResult> run(MachineFunction &Function,
-                                                const TargetDescription &Target,
-                                                MachineAnalysisManager &Analyses) override;
-
-private:
-  const TargetRegisterBankInfo *Info;
-};
-
-class InstructionSelectPass final : public MachineFunctionPass {
-public:
-  explicit InstructionSelectPass(const TargetInstructionSelector *Info) : Info(Info) {}
-  explicit InstructionSelectPass(const TargetInstructionSelector &Info) : Info(&Info) {}
-
-  [[nodiscard]] const MachinePassContract &contract() const noexcept override;
-  [[nodiscard]] Expected<MachinePassResult> run(MachineFunction &Function,
-                                                const TargetDescription &Target,
-                                                MachineAnalysisManager &Analyses) override;
-
-private:
-  [[nodiscard]] Expected<MachinePassResult> runImplementation(MachineFunction &Function,
-                                                              const TargetDescription &Target,
-                                                              MachineActionReplay &Actions);
-
-  const TargetInstructionSelector *Info;
-};
-
-} // namespace rcc
-
-#endif // RCC_CODEGEN_MACHINEPIPELINEPASSES_H
diff --git a/backend/include/rcc/CodeGen/RegisterBankInfo.h b/backend/include/rcc/CodeGen/RegisterBankInfo.h
new file mode 100644
index 0000000..70b7340
--- /dev/null
+++ b/backend/include/rcc/CodeGen/RegisterBankInfo.h
@@ -0,0 +1,39 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+#ifndef RCC_CODEGEN_REGISTERBANKINFO_H
+#define RCC_CODEGEN_REGISTERBANKINFO_H
+
+#include "rcc/CodeGen/MachineIRTypes.h"
+#include "rcc/CodeGen/Register.h"
+#include "rcc/Support/Error.h"
+
+namespace rcc {
+
+class MachineFunction;
+class MachineInstr;
+class TargetDescription;
+struct VirtualRegisterInfo;
+
+class RegisterBankInfo {
+public:
+  virtual ~RegisterBankInfo() = default;
+
+  [[nodiscard]] virtual Expected<RegisterBankID>
+  selectBank(const MachineFunction &Function, Register Reg, const VirtualRegisterInfo &Info,
+             const MachineInstr *Context, const TargetDescription &Target) const = 0;
+
+  [[nodiscard]] virtual Expected<void>
+  constrainInstruction(MachineInstr &Instruction, MachineFunction &Function,
+                       const TargetDescription &Target) const = 0;
+
+  // This hook rejects invalid mappings before bank or register-class state is published.
+  [[nodiscard]] virtual Expected<void> validateInstruction(const MachineInstr &,
+                                                           const MachineFunction &,
+                                                           const TargetDescription &) const {
+    return {};
+  }
+};
+
+} // namespace rcc
+
+#endif // RCC_CODEGEN_REGISTERBANKINFO_H
diff --git a/backend/include/rcc/CodeGen/TargetCodeGen.h b/backend/include/rcc/CodeGen/TargetCodeGen.h
deleted file mode 100644
index 65f65a4..0000000
--- a/backend/include/rcc/CodeGen/TargetCodeGen.h
+++ /dev/null
@@ -1,95 +0,0 @@
-// SPDX-License-Identifier: GPL-3.0-or-later
-
-#ifndef RCC_CODEGEN_TARGETCODEGEN_H
-#define RCC_CODEGEN_TARGETCODEGEN_H
-
-#include "rcc/Support/Error.h"
-
-#include <cstdint>
-
-namespace rcc {
-
-class MachineFunction;
-class MachineInstr;
-class TargetDescription;
-struct VirtualRegisterInfo;
-
-enum class LegalizationAction : std::uint8_t {
-  Legal,
-  Unsupported,
-  Custom,
-  Lower,
-  Libcall,
-  WidenScalar,
-  NarrowScalar,
-  MoreElements,
-  FewerElements,
-  Bitcast,
-  ChangeElementType,
-  ChangeAddressSpace,
-};
-
-class TargetLegalizerInfo {
-public:
-  virtual ~TargetLegalizerInfo() = default;
-
-  [[nodiscard]] virtual Expected<LegalizationAction>
-  classify(const MachineInstr &Instruction, const MachineFunction &Function,
-           const TargetDescription &Target) const = 0;
-
-  [[nodiscard]] virtual Expected<void> lower(MachineInstr &Instruction, MachineFunction &Function,
-                                             const TargetDescription &Target,
-                                             LegalizationAction Action) const = 0;
-
-  // This hook performs read-only target checks before a lowering mutation is committed.
-  [[nodiscard]] virtual Expected<void> validateLowering(const MachineInstr &,
-                                                        const MachineFunction &,
-                                                        const TargetDescription &,
-                                                        LegalizationAction) const {
-    return {};
-  }
-};
-
-class TargetRegisterBankInfo {
-public:
-  virtual ~TargetRegisterBankInfo() = default;
-
-  [[nodiscard]] virtual Expected<RegisterBankID>
-  selectBank(const MachineFunction &Function, Register Reg, const VirtualRegisterInfo &Info,
-             const MachineInstr *Context, const TargetDescription &Target) const = 0;
-
-  [[nodiscard]] virtual Expected<void>
-  constrainInstruction(MachineInstr &Instruction, MachineFunction &Function,
-                       const TargetDescription &Target) const = 0;
-
-  // This hook must not mutate MachineIR. It allows the pass to reject a bad mapping
-  // before publishing any bank or class assignment.
-  [[nodiscard]] virtual Expected<void> validateInstruction(const MachineInstr &,
-                                                           const MachineFunction &,
-                                                           const TargetDescription &) const {
-    return {};
-  }
-};
-
-class TargetInstructionSelector {
-public:
-  virtual ~TargetInstructionSelector() = default;
-
-  [[nodiscard]] virtual Expected<void> select(MachineInstr &Instruction, MachineFunction &Function,
-                                              const TargetDescription &Target) const = 0;
-
-  // Selection matching is read-only and must complete before select() mutates MachineIR.
-  [[nodiscard]] virtual Expected<void> canSelect(const MachineInstr &, const MachineFunction &,
-                                                 const TargetDescription &) const {
-    return {};
-  }
-
-  [[nodiscard]] virtual Expected<void>
-  constrainSelectedInstruction(MachineInstr &, MachineFunction &, const TargetDescription &) const {
-    return {};
-  }
-};
-
-} // namespace rcc
-
-#endif // RCC_CODEGEN_TARGETCODEGEN_H